Skip to content

fix(jev): review follow-ups for the Surplus provider - #180

Merged
senamakel merged 2 commits into
mainfrom
surplus-jev-review-followup
Nov 15, 2026
Merged

senamakel merged 2 commits into
mainfrom
surplus-jev-review-followup

Conversation

@senamakel

Copy link
Copy Markdown
Member

Follow-up to #179, addressing two CodeRabbit findings that landed after merge: the versioning.md examples still showed contract 3.2 (the is_compatible((3, 2)) example would now fail), and a Surplus configuration lacked an in-memory-bus test through Describe. Docs and tests only.

senamakel and others added 2 commits November 15, 2026 05:47
Update the versioning guide to reflect CONTRACT_VERSION (3, 3) and adjust the compatibility examples accordingly. Add a case showing that a (3, 2) module is now rejected because it lacks the `surplus` provider.

Auto-committed-on: cuttlefish
Co-authored-by: Medulla <medulla@tinyhumans.ai>
Add an async test that sets up the module with a surplus JEV configuration on an in-memory bus and asserts that describe reports the expected provider and model, exercising the configuration path end to end.

Auto-committed-on: cuttlefish
Co-authored-by: Medulla <medulla@tinyhumans.ai>
@coderabbitai

coderabbitai Bot commented Nov 15, 2026

Copy link
Copy Markdown

Warning

Review limit reached

  • Run on-demand review

This review includes 2 billable files and costs up to $0.50.

Or wait 33 minutes for your next included review.

Check out review usage here.

View limit details

Limit details: You’ve used the included review currently available.

Learn how review limits work.

Review configuration:

Run configuration

  • Source mode: Auto
  • Repository: Unavailable
  • Branch: Unavailable
  • File: No configuration file from this repository applied
  • Commit: Unavailable
  • Layers: Organization UI
  • Review profile: CHILL
  • Plan: Advanced
  • Run ID: ab1aef3c-65e5-4d85-ae8d-eb6ee30a09c2
Commits

Reviewing files that changed from the base of the PR and between 127f4f9 and dbb397a.

Files selected for processing: 2

  • crates/tinycomputer/src/tinybus_module/tinybus_module_tests/config_tests.rs
  • docs/crates/tinycomputer-bus/versioning.md
  • Autofix · Keep fixing CodeRabbit findings and required CI, and resolving merge conflicts

@chatgpt-codex-connector

chatgpt-codex-connector Bot commented Nov 15, 2026 •

Copy link
Copy Markdown
Codex Review Summary: ✅ Completed

This comment shows the latest Codex review activity on this pull request.

Review Status Commit Review trigger
📝 Code Review ✅ Completed 2026-11-15T05:49:21.124026Z dbb397a PR opened
ℹ️ About Codex in GitHub

Your team has set up Codex to review pull requests in this repo. Reviews are triggered when you

  • Open a pull request for review
  • Mark a draft as ready
  • Comment "@codex review" or "@codex security review".

Codex reacts with 👀 while any review is running, comments if it has suggestions, and reacts with 👍 once all reviews finish with no findings.

@senamakel
senamakel merged commit f16d63b into main Nov 15, 2026
14 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

1 participant